Update SignOptions to fix a type error #1436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
force-pushed
the
lm-fix-jwt-types
branch
from
afe7cd1
to
2b40284
Compare
hiranya911
suggested changes
Sep 23, 2021
| @@ -309,3 +315,12 @@ export const messaging = { | |||
| dryRun: true, | |||
| }, | |||
| }; | |||
|
|
|||
| function copyAlgorithmToHeader(options: SignOptions, overrides?: object): SignOptions { | |||
There was a problem hiding this comment.
We might be able to type overrides as Partial<SignOptions>. That should make some of the type casts go away.
| function copyAlgorithmToHeader(options: SignOptions, overrides?: object): SignOptions { | ||
| // The following allows us to override the alg in header without replacing the kid. | ||
| if (validator.isNonNullObject(overrides) && validator.isNonNullObject(options.header) && | ||
| Object.prototype.hasOwnProperty.call(overrides, 'algorithm')) { |
There was a problem hiding this comment.
Just overrides.hasOwnProperty()?
| @@ -77,7 +77,7 @@ | |||
| "@types/chai": "^4.0.0", | |||
| "@types/chai-as-promised": "^7.1.0", | |||
| "@types/firebase-token-generator": "^2.0.28", | |||
| "@types/jsonwebtoken": "^8.5.0", | |||
| "@types/jsonwebtoken": "^8.5.5", | |||
There was a problem hiding this comment.
I'm wondering if we should just downgrade and pin this dependency to v8.5.1. Implementing all these workarounds to deal with a badly versioned dependency doesn't sound very good to me. WDYT?
There was a problem hiding this comment.
Agreed. Created a new PR to pin the dependency. I will close this for now.
|
Decided to pin the dependency to 8.5.1 for now #1438. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
@types/jsonwebtoken@8.5.5the data type of the propertyheaderwas changed fromheader: objecttoheader: JWTHeader. This results in type errors in our test build. This PR fixes it by setting thealginheaderand removing the optionalalgorithmfrom the top level.