Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build integration tests during CI (and release) #800

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Build integration tests during CI (and release) #800

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
504eebc
Build integration tests during CI (and release)
rsgowman Mar 3, 2020
265c2dc
Purposely introduce an integration test compilation error (that passe…
rsgowman Mar 3, 2020
5732ffe
Revert the integration test compilation error
rsgowman Mar 3, 2020
7a7f21e
Compile integration tests before running unit tests.
rsgowman Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ jobs:
npm ci
npm run build
npm test
npm run build:tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Move this before npm test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
run: |
npm ci
npm run build
npm run build:tests

- name: Run unit tests
run: npm test
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
},
"scripts": {
"build": "gulp build",
"build:tests": "gulp compile_test",
"prepare": "npm run build",
"lint": "run-p lint:src lint:test",
"test": "run-s lint test:unit",
Expand Down