-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rc): Add Remote Config Version Management API #920
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e7af8bb
Get remote config template by version number (#874)
lahirumaramba 773add8
Refactor unit tests for Remote Config (#884)
lahirumaramba 5762470
Add Remote Config Rollback operation (#885)
lahirumaramba bde53cc
Remote Config Add list versions operation (#896)
lahirumaramba 16b20f1
Add a separate function to get a Template with version (#902)
lahirumaramba cf10110
Add version meta data to RC templates (#906)
lahirumaramba a1e589f
Update Remote Config Docstrings in index.d.ts
lahirumaramba 0438241
Merge branch 'master' into remote-config-vc
lahirumaramba File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest a bit of a rewrite:
"The version number of
the Remote Config template that has become the current version due to a rollback. Only present if this version is the result of a rollback."
Is this accurate? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is accurate! Thanks. Updated.