fix: Upgraded Chai, Sinon and other test dependencies #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
requested review from
ifielker,
bojeil-google,
lahirumaramba and
nbegley
nbegley
approved these changes
Jul 9, 2020
lahirumaramba
approved these changes
Jul 10, 2020
bojeil-google
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using several heavily outdated test dependencies, and this PR upgrades them to the latest versions:
The biggest change stems from the Chai upgrade, where the latest versions of Chai do not allow
deep.equalsassertions onErrortypes. See chaijs/chai#1009. Therefore I had to usedeep.includein all the places where we directly compareErrorobjects.The latest versions of Sinon also have better TS support which caused several TS compilation errors in tests. I've fixed those instances too.