Fall back to updateTime if no readTime exists (#843)

Fixes #599
firebase · Jun 24, 2021 · 4028acc · 4028acc
1 parent 8858937
commit 4028acc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/spec/providers/firestore.spec.ts b/spec/providers/firestore.spec.ts
@@ -566,6 +566,7 @@ describe('Firestore Functions', () => {
 
     describe('Other DocumentSnapshot methods', () => {
       let snapshot: FirebaseFirestore.DocumentSnapshot;
+      let newSnapshot: FirebaseFirestore.DocumentSnapshot;
 
       before(() => {
         snapshot = firestore.snapshotConstructor(
@@ -579,6 +580,16 @@ describe('Firestore Functions', () => {
             },
           })
         );
+        newSnapshot = firestore.snapshotConstructor(
+          makeEvent({
+            value: {
+              fields: { key: { integerValue: '2' } },
+              createTime: '2017-06-17T14:45:17.876479Z',
+              updateTime: '2017-06-17T14:45:17.876479Z',
+              name: 'projects/pid/databases/(default)/documents/collection/124',
+            },
+          })
+        );
       });
 
       it('should support #exists', () => {
@@ -606,6 +617,8 @@ describe('Firestore Functions', () => {
       it('should support #readTime', () => {
         expect(snapshot.readTime.seconds).to.be.a('number');
         expect(snapshot.readTime.nanoseconds).to.be.a('number');
+        expect(newSnapshot.readTime.seconds).to.be.a('number');
+        expect(newSnapshot.readTime.nanoseconds).to.be.a('number');
       });
     });
 

diff --git a/src/providers/firestore.ts b/src/providers/firestore.ts
@@ -155,7 +155,10 @@ export function snapshotConstructor(event: Event): DocumentSnapshot {
     event.context.resource.name,
     'value'
   );
-  const readTime = dateToTimestampProto(_.get(event, 'data.value.readTime'));
+  const timeString =
+    _.get(event, 'data.value.readTime') ??
+    _.get(event, 'data.value.updateTime');
+  const readTime = dateToTimestampProto(timeString);
   return firestoreInstance.snapshot_(valueProto, readTime, 'json');
 }