Fix common identity package internal toJSON function (#1125)

* fixing the toJSON function

* fix nit

* adding changelog

CHANGELOG.md

@@ -0,0 +1 @@
+- Fixes bug where `toJSON` was not defined in `UserRecord` (#1125).

spec/common/providers/identity.spec.ts

@@ -88,6 +88,34 @@ describe('identity', () => {
         lastSignInTime: '2017-02-02T23:01:19.797Z',
       });
     });
+
+    it('should stringify the record', () => {
+      const raw: any = {
+        uid: '123',
+        email: 'email@gmail.com',
+        emailVerified: true,
+        displayName: 'User',
+        photoURL: 'url',
+        phoneNumber: '1233332222',
+        disabled: true,
+        providerData: ['something'],
+        customClaims: {
+          claim: 'value',
+          another: {
+            inner: 'value',
+          },
+        },
+        passwordSalt: 'abc',
+        passwordHash: 'def',
+        tokensValidAfterTime: '2027-02-02T23:01:19.797Z',
+        metadata: {
+          creationTime: '2017-02-02T23:06:26.124Z',
+          lastSignInTime: '2017-02-02T23:01:19.797Z',
+        },
+      };
+      const record = identity.userRecordConstructor(raw);
+      expect(() => JSON.stringify(record)).to.not.throw;
+    });
   });
 
   describe('isValidRequest', () => {

src/common/providers/identity.ts

@@ -146,7 +146,11 @@ export function userRecordConstructor(wireData: Object): UserRecord {
     };
     json.metadata = record.metadata.toJSON();
     json.customClaims = JSON.parse(JSON.stringify(record.customClaims));
-    json.providerData = record.providerData.map((entry) => entry.toJSON());
+    json.providerData = record.providerData.map((entry) => {
+      const newEntry = { ...entry };
+      newEntry.toJSON = () => entry;
+      return newEntry;
+    });
     return json;
   };
   return record as UserRecord;