Added eventarc onCustomEventPublished API #1061
Conversation
pavelgj
force-pushed
the
pavelj-eventarc-custom
branch
from
f4c98df
to
ab337eb
Compare
There was a problem hiding this comment.
You'd also want to update package.json, e.g.
LGTM - deferring approval to @colerogers
pavelgj
force-pushed
the
pavelj-eventarc-custom
branch
2 times, most recently
from
edf2f82
to
12cbeef
Compare
| { | ||
| ...FULL_OPTIONS, | ||
| eventType: 'event-type', | ||
| channel: 'locations/us-west1/channels/my-channel', |
There was a problem hiding this comment.
Per the partial resource name resolution, I think we should also have a test that verifies "my-channel" gets turned into locations/us-central1/channels/my-channel
There was a problem hiding this comment.
On the functions SDK side I'm only doing the: if channel is not specified, default it to 'locations/us-central1/channels/firebase'. The rest of the partial channel resource name resolution (and validation) is done on the CLI side.
The reason it's done this way is because if channel is not specified, in the container contract I can't distinguish between: it's not specified and expected to be resolved to default vs not specified and should remain undefined.
There was a problem hiding this comment.
Sounds good. And the more code we put in the "agent" (e.g. CLI, control plane) the less we have to redefine in the SDKs.
Co-authored-by: Daniel Lee <taeold@gmail.com>
Co-authored-by: Daniel Lee <taeold@gmail.com>
pavelgj
force-pushed
the
pavelj-eventarc-custom
branch
from
f6c38c2
to
e9784de
Compare
go/rvtfmkswhlks