add firebase-admin@11.0.0 to peerDependencies #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manokii
changed the title
|
Thanks! |
|
@taeold when do you expect this to land? |
|
merge ? as this is currently fundamentally broken. You cant just do this: AS latest version 11 has wrong dependency... |
inlined
approved these changes
Jun 28, 2022
|
We're still working out a timeline for vNext, though it should be "soon". If it turns out to be an unreasonable amount of time we'll release a patch update that adds the new peer dependency. |
|
Thx for quick merge, we can only hope for patch/new version now... |
|
@radvansky-tomas @Manokii w 3.22.0 is out I just saw (3d ago) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some CI fails after upgrading to firebase-admin@11.0.0.
This is because firebase cloud-functions does not recognize firebase-admin@11.0.0 as peer dependency
fixes: #1147
closing #1151 and opening this new pr using
launch.nextbranch