Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setNumberOfStackFramesToSkipForNotFatalErrors #11476

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

paulz
Copy link

@paulz paulz commented Jun 26, 2023

Proposal for #11475

API Changes

  • This is a proposal to add a method to set number of stack trace frames to be skipped for non-fatal errors.

Similar to Bugsnag: https://docs.bugsnag.com/platforms/ios/customizing-error-reports/#modifying-stack-traces

@google-cla
Copy link

google-cla bot commented Jun 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@paulb777
Copy link
Member

paulb777 commented Jul 6, 2023

Thanks for the PR and sorry about the delayed response. Please sign the CLA

@paulz
Copy link
Author

paulz commented Jul 7, 2023

Thanks for the PR and sorry about the delayed response. Please sign the CLA

Done ✅

@paulb777
Copy link
Member

paulb777 commented Jul 7, 2023

Thanks! Looks like CI is showing some test failures.

@paulz
Copy link
Author

paulz commented Jul 9, 2023

Thanks! Looks like CI is showing some test failures.

I've added unit test, hope CI will pass now.

rename stackFramesToSkip
@paulz
Copy link
Author

paulz commented Sep 2, 2023

@paulb777 @samedson is there any chance to merge this?

@ncooke3
Copy link
Member

ncooke3 commented Sep 4, 2023

Hi @paulz, I'll sync with Sam about this PR this week. Since it's changing the public API surface, there's an internal API review process it'll need to go through before merging. I'll keep you in the loop– thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants