Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #5296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jacoblukewood
Copy link

@jacoblukewood jacoblukewood commented Aug 13, 2021

Required for Vite as per vitejs/vite#1505

#4725 added the exports as needed but this one was missing and did not allow projects such as those using SvelteKit to build.

Required for Vite as per vitejs/vite#1505

firebase#4725 added the exports as needed but this one was missing and did not allow projects such as those using SvelteKit to build.
@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2021

⚠️ No Changeset found

Latest commit: 4a023f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1
Copy link
Member

Feiyang1 commented Aug 13, 2021

Thanks for the contribution! I don't think it's needed though, because you will never use firebase as an import in v9. Instead, you will only use submodule imports like firebase/app, firebase/firestore, etc. As a result, we deliberately didn't add the exports for the main module to prevent people from importing from firebase.

I have tested the v9 SDK with sveltekit and it worked correctly. If it is not the case, can you help me understand your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants