Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exports to all packages #5646

Merged
merged 36 commits into from
Nov 2, 2021
Merged

Add exports to all packages #5646

merged 36 commits into from
Nov 2, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Oct 21, 2021

Fixes #4846

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little confused about which builds need the emitModulePackageFile() plugin and which don't. Some seemed to be missing, but maybe there's a reason. I made a comment about how multiple instances of that plugin might be redundant if writing to the same directory but I don't think that applies to all "missing" plugin cases so maybe there's another reason they're not needed in those cases.

packages/analytics-compat/rollup.config.js Outdated Show resolved Hide resolved
packages/analytics-compat/rollup.config.js Show resolved Hide resolved
packages/app-check-compat/rollup.shared.js Show resolved Hide resolved
packages/app-compat/rollup.config.js Outdated Show resolved Hide resolved
packages/auth-compat/rollup.config.js Outdated Show resolved Hide resolved
packages/auth-compat/rollup.config.js Outdated Show resolved Hide resolved
packages/auth/rollup.config.js Show resolved Hide resolved
packages/database/rollup.config.js Outdated Show resolved Hide resolved
packages/firestore-compat/rollup.config.js Show resolved Hide resolved
packages/firestore/package.json Outdated Show resolved Hide resolved
@hsubox76 hsubox76 assigned Feiyang1 and unassigned hsubox76 Oct 27, 2021
@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Oct 28, 2021
Copy link

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! thank you so much for this!

packages/analytics-compat/package.json Outdated Show resolved Hide resolved
@kenkunz
Copy link

kenkunz commented Nov 2, 2021

As a SvelteKit + Firebase developer, very happy to see this 👍. Thanks!

@Feiyang1 Feiyang1 merged commit 0b3ca78 into master Nov 2, 2021
@Feiyang1 Feiyang1 deleted the fei-exports branch November 2, 2021 22:37
@Feiyang1 Feiyang1 mentioned this pull request Nov 2, 2021
@firebase firebase locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing getFunctions() throws "self is not defined" during SSR/Static (v9-beta)
5 participants