Fix storage emulator tests #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
approved these changes
Mar 16, 2022
src/components/Storage/Card/Table/Header/StorageHeader/CreateFolder/CreateFolder.test.tsx
Outdated
Show resolved
Hide resolved
yuchenshi
approved these changes
Mar 17, 2022
tjlav5
added a commit
that referenced
this pull request
Mar 17, 2022
* Fix development demo-project reference (#715) * Fix development demo-project reference Project ID for demo-configuration is "demo-exmaple" * Fix package lock * fix(npm run bundle): clean bundle every time * chore(deps): bump url-parse from 1.5.3 to 1.5.10 (#718) Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.3...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix Firestore viewer UI (#721) * Fix firestore styles * Add CollectionList.scss * Fix storage emulator tests (#727) * skip timing out test * fix tests Co-authored-by: Yuchen Shi <yuchenshi@google.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yuki Tanabe <tanabee1986@gmail.com> Co-authored-by: Tony Huang <tony.huang.jun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since firebase/firebase-tools#3647 was merged, the list endpoint now exhibits different (more correct) behavior than what the integration tests in this repo was testing against. This PR fixes the assertions in the integration tests to match the new live version of the storage
emulator.
Note: firebase/firebase-tools#3647 introduces a new visual bug in the emulator wherein zero-byte files that denote empty folders are now shown in the file browser.
The behavior of the storage emulator is correct in this case, but the view logic of the UI needs to filter out these files before rendering. Files #728 to track.