Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update each emulator page with a title and heading. #928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update each emulator page with a title and heading. #928

wants to merge 2 commits into from

Conversation

christhompsongoogle
Copy link
Collaborator

@christhompsongoogle christhompsongoogle commented Mar 17, 2023 •
edited

Update each emulator page with a title and heading. The inconsistent use of breaks is to minimize the vertical space used on some pages while adding a bit of margin on others.

yuchenshi
yuchenshi approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this change, but have we considered making some of the titles screen-reader-only? It may help us regain a bit of vertical space (especially on the Firestore viewer page)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

Assignees

@joehan joehan

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christhompsongoogle @joehan @yuchenshi