Skip to content

Commit

Permalink
Fix bug where migration of config-clone command to TS broke the comma…
Browse files Browse the repository at this point in the history
…nd. (#4173)

While migrating the command to TS in #4025, we introduced a small bug that effectively broke the `functions:config:clone` command that did not pass the `--only` flag.

Fixes #4112
  • Loading branch information
taeold committed Feb 16, 2022
1 parent 02941bd commit 1be06d3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fixes an issue where ext:list was not printing out information about installed Extension instances.
- Fixes issue where Functions Emulator crashed when parsing triggers if accessing functions config values.
- Fixes an issue where ext:list was not printing out information about installed Extension instances (#4156)
- Fixes issue where Functions Emulator crashed when parsing triggers if accessing functions config values (#4162).
- `firebase emulators:start --export-on-exit <dir>` now rejects overwriting the current directory or parents (#4127).
- Fixes broken functions:config:clone command (#4173).
2 changes: 1 addition & 1 deletion src/commands/functions-config-clone.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default new Command("functions:config:clone")
throw new FirebaseError("Cannot use both --only and --except at the same time.");
}

let only: string[] = [];
let only: string[] | undefined;
let except: string[] = [];
if (options.only) {
only = options.only.split(",");
Expand Down

0 comments on commit 1be06d3

Please sign in to comment.