Handle CSM response without secrets (#4425)

firebase · Apr 9, 2022 · 2abaa02 · 2abaa02
1 parent de4d715
commit 2abaa02
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,3 +5,4 @@
 - Improves support for prerelease versions in `ext:dev:publish` (#4244).
 - Fixes console error on large uploads to Storage Emulator (#4407).
 - Fixes cross-platform incompatibility with Storage Emulator exports (#4411).
+- Fixes issue where function deployment errored on projects without secrets (#4425).
diff --git a/src/gcp/secretManager.ts b/src/gcp/secretManager.ts
@@ -91,7 +91,7 @@ export async function listSecrets(projectId: string, filter?: string): Promise<S
         : { ...baseOpts, queryParams: { ...baseOpts?.queryParams, pageToken } };
     const res = await client.get<Response>(path, opts);
 
-    for (const s of res.body.secrets) {
+    for (const s of res.body.secrets || []) {
       secrets.push({
         ...parseSecretResourceName(s.name),
         labels: s.labels ?? {},