Add missing changelog entry for #3499 (#3500)

firebase · Jun 16, 2021 · 497728d · 497728d
1 parent ac875c4
commit 497728d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1 @@
+- Fixes an issue with ext:update where local extension is incorrectly inferred as published (#3499)
diff --git a/src/test/extensions/updateHelper.spec.ts b/src/test/extensions/updateHelper.spec.ts
@@ -599,38 +599,44 @@ describe("getExistingSourceOrigin", () => {
     isOfficialStub = sinon.stub(resolveSource, "isOfficialSource");
     isOfficialStub.returns(true);
     getInstanceStub = sinon.stub(extensionsApi, "getInstance").resolves(INSTANCE);
+
     const result = await updateHelper.getExistingSourceOrigin(
       "invader-zim",
       "instance-of-official-ext",
       "ext-testing",
       "projects/firebasemods/sources/fake-official-source"
     );
+
     expect(result).to.equal(extensionsHelper.SourceOrigin.OFFICIAL_EXTENSION);
   });
 
   it("should return published extension as source origin", async () => {
     registryEntryStub = sinon.stub(resolveSource, "resolveRegistryEntry");
     registryEntryStub.throwsException("Entry not found");
     getInstanceStub = sinon.stub(extensionsApi, "getInstance").resolves(REGISTRY_INSTANCE);
+
     const result = await updateHelper.getExistingSourceOrigin(
       "invader-zim",
       "instance-of-registry-ext",
       "ext-testing",
       "projects/firebasemods/sources/fake-registry-source"
     );
+
     expect(result).to.equal(extensionsHelper.SourceOrigin.PUBLISHED_EXTENSION);
   });
 
   it("should return local extension as source origin", async () => {
     registryEntryStub = sinon.stub(resolveSource, "resolveRegistryEntry");
     registryEntryStub.throwsException("Entry not found");
     getInstanceStub = sinon.stub(extensionsApi, "getInstance").resolves(LOCAL_INSTANCE);
+
     const result = await updateHelper.getExistingSourceOrigin(
       "invader-zim",
       "instance-of-local-ext",
       "ext-testing",
       "projects/firebasemods/sources/fake-local-source"
     );
+
     expect(result).to.equal(extensionsHelper.SourceOrigin.LOCAL);
   });
 
@@ -640,12 +646,14 @@ describe("getExistingSourceOrigin", () => {
     isOfficialStub = sinon.stub(resolveSource, "isOfficialSource");
     isOfficialStub.returns(false);
     getInstanceStub = sinon.stub(extensionsApi, "getInstance").resolves(LOCAL_INSTANCE);
+
     const result = await updateHelper.getExistingSourceOrigin(
       "invader-zim",
       "instance-of-local-ext",
       "ext-testing",
       "projects/firebasemods/sources/fake-local-source"
     );
+
     expect(result).to.equal(extensionsHelper.SourceOrigin.LOCAL);
   });
 });