Handle firebaseStorageDownloadTokens for objects: rewrite / copy

firebase · Aug 25, 2021 · fb04288 · fb04288
1 parent 33c6b2f
commit fb04288
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 2 deletions.
diff --git a/scripts/storage-emulator-integration/tests.ts b/scripts/storage-emulator-integration/tests.ts
@@ -758,6 +758,52 @@ describe("Storage emulator", () => {
           expect(metadata2).to.deep.equal(metadata1);
         });
 
+        it("should preserve firebaseStorageDownloadTokens", async () => {
+          const firebaseStorageDownloadTokens = "token1,token2";
+          await testBucket.upload(smallFilePath, {
+            metadata: {
+              metadata: {
+                firebaseStorageDownloadTokens,
+              },
+            },
+          });
+
+          const file = testBucket.file(copyDestinationFile);
+          const [, { resource: metadata }] = await testBucket
+            .file(smallFilePath.split("/").slice(-1)[0])
+            .copy(file);
+
+          expect(metadata).to.deep.include({
+            metadata: {
+              firebaseStorageDownloadTokens,
+            },
+          });
+        });
+
+        it("should remove firebaseStorageDownloadTokens when overwriting custom metadata", async () => {
+          await testBucket.upload(smallFilePath, {
+            metadata: {
+              metadata: {
+                firebaseStorageDownloadTokens: "token1,token2",
+              },
+            },
+          });
+
+          const file = testBucket.file(copyDestinationFile);
+          const metadata = { foo: "bar" };
+          // Types for CopyOptions are wrong (@google-cloud/storage sub-dependency needs
+          // update to include https://github.com/googleapis/nodejs-storage/pull/1406
+          // and https://github.com/googleapis/nodejs-storage/pull/1426)
+          const copyOpts: CopyOptions & { [key: string]: unknown } = {
+            metadata,
+          };
+          const [, { resource: metadataOut }] = await testBucket
+            .file(smallFilePath.split("/").slice(-1)[0])
+            .copy(file, copyOpts);
+
+          expect(metadataOut).to.deep.include({ metadata });
+        });
+
         it("should not support the use of a rewriteToken", async () => {
           await testBucket.upload(smallFilePath);
 

diff --git a/src/emulator/storage/files.ts b/src/emulator/storage/files.ts
@@ -333,11 +333,18 @@ export class StorageLayer {
       return;
     }
 
-    const newMetadata: IncomingMetadata = {
+    const newMetadata = {
       ...sourceMetadata,
-      metadata: sourceMetadata.customMetadata,
+      metadata: sourceMetadata.customMetadata ?? {},
       ...metadata,
     };
+    if (
+      sourceMetadata.downloadTokens.length &&
+      // Only copy download tokens if we're not overwriting any custom metadata
+      !(metadata?.metadata && Object.keys(metadata?.metadata).length)
+    ) {
+      newMetadata.metadata.firebaseStorageDownloadTokens = sourceMetadata.downloadTokens.join(",");
+    }
     if (newMetadata.metadata) {
       // Convert null metadata values to empty strings
       for (const k of Object.keys(newMetadata.metadata)) {