Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arg order for Storage Emulator start command #4195

Merged
merged 2 commits into from Feb 18, 2022

Conversation

tohhsinpei
Copy link
Member

Description

Issue

The Storage Emulator crashes on start for me on OpenJDK 11.0.12. The only error logs are

$ firebase emulators:start --only storage
i  emulators: Starting emulators: storage

Error: There was an issue starting the rules emulator, please run 'firebase setup:emulators:storage` again

Error: Storage Emulator Rules runtime exited unexpectedly.

Cause

The args passed in the start command are in the wrong order: java -jar -Duser.language=en <jarfile> serve instead of java -Duser.language=en -jar <jarfile> serve as recommended. This causes -Duser.language=en to be mistakenly interpreted as the JAR file:

Error: Unable to access jarfile -Duser.language=en

This PR also adds the above message to the error logs.

Scenarios Tested

Tested the above commands on the command line to confirm that the program launches successfully with the new order:

{"result":{},"id":-1,"status":"ok"}

Also verified that the Storage Emulator is launched successfully with the fix.

@tohhsinpei tohhsinpei changed the title Fix arg order for Storage Emulator command Fix arg order for Storage Emulator start command Feb 18, 2022
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a CHANGELOG entry

@tohhsinpei tohhsinpei merged commit feaee21 into master Feb 18, 2022
@tohhsinpei tohhsinpei deleted the hsinpei/storage-cli-args branch February 18, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants