Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arg order for Storage Emulator start command #4195

Merged
merged 2 commits into from
Feb 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Updates reserved environment variables for CF3 to include 'EVENTARC_CLOUD_EVENT_SOURCE' (#4196).
- Fixes arg order for `firebase emulators:start --only storage` (#4195).
2 changes: 1 addition & 1 deletion src/emulator/downloadableEmulators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ const Commands: { [s in DownloadableEmulators]: DownloadableEmulatorCommand } =
// separately in ./storage/runtime.ts (not via the start function below).
binary: "java",
args: [
"-jar",
// Required for rules error/warning messages, which are in English only.
// Attempts to fetch the messages in another language leads to crashes.
"-Duser.language=en",
"-jar",
getExecPath(Emulators.STORAGE),
"serve",
],
Expand Down
1 change: 1 addition & 0 deletions src/emulator/storage/rules/runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ export class StorageRulesRuntime {
this._childprocess.stderr?.on("data", (buf: Buffer) => {
const error = buf.toString();
if (error.includes("jarfile")) {
EmulatorLogger.forEmulator(Emulators.STORAGE).log("ERROR", error);
throw new FirebaseError(
"There was an issue starting the rules emulator, please run 'firebase setup:emulators:storage` again"
);
Expand Down