Fix Storage Emulator rules resource evaluation #4214
Merged
+47
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjhuang
requested changes
Feb 23, 2022
tohhsinpei
force-pushed
the
hsinpei/storage-write-rules
branch
from
39504ff to
f3e14fe
Compare
tonyjhuang
requested changes
Feb 25, 2022
tohhsinpei
force-pushed
the
hsinpei/storage-write-rules
branch
from
f3e14fe to
0ac2a9f
Compare
tohhsinpei
force-pushed
the
hsinpei/storage-write-rules
branch
from
0ac2a9f to
18a6142
Compare
tonyjhuang
approved these changes
Feb 25, 2022
yuchenshi
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Fixes #3760.
The
resourceobject was not being evaluated correctly in security rules for the Storage Emulator. AnEvaluationExceptionis thrown and the user receives a null value error. Moreover, the corresponding rule is not enforced.Cause
The file metadata corresponding to the
resourceobject was not being passed to the evaluator binary.Scenarios Tested
Added additional security rule evaluating
resourceand verified that existing integration tests now pass with the fix.