Fix Storage Emulator resource evaluation integration test #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohhsinpei
force-pushed
the
hsinpei/storage-write-rules-2
branch
from
438d51f
to
140d366
Compare
tonyjhuang
approved these changes
Feb 28, 2022
yuchenshi
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Follow up to #4214. We added an integration test to check that the
resourceobject is evaluated correctly in the security rules for the Storage Emulator. This test is currently failing onmaster.Cause
updateMetadatais not being awaited, so the file metadata is not set. Thus the security rule condition allows the delete.Scenarios Tested
Ran Storage Emulator integration tests and verified that test now passes with fix.