Fix issue with importing Storage Emulator data with nested directory structure #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohhsinpei
force-pushed
the
hsinpei/fix-emulator-directory-flatten
branch
from
988d016
to
862b848
Compare
tohhsinpei
force-pushed
the
hsinpei/fix-emulator-directory-flatten
branch
4 times, most recently
from
ef1341b
to
62a5632
Compare
tohhsinpei
force-pushed
the
hsinpei/fix-emulator-directory-flatten
branch
from
62a5632
to
f266de4
Compare
tohhsinpei
force-pushed
the
hsinpei/fix-emulator-directory-flatten
branch
from
f266de4
to
372d71d
Compare
tonyjhuang
approved these changes
Mar 29, 2022
This was referenced Mar 30, 2022
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
This PR fixes #4326.
Importing any Storage data exported prior to v10.3.0 causes the emulator to crash.
Cause
In #3647 (released as part of v10.3.0), we flattened the emulator directory structure. However, this is not backwards-compatible with previously exported data, which still contains the nested directory structure. In particular, when we copy the imported data, we copy over the old nested directories.
Scenarios Tested
Tested against example provided in issue and verified that crash does not occur and that we are able to view the file:
Also wrote two integration tests, one testing import of old nested structure, another testing import of new flattened structure. These will be run as part of
npm run test:storage-emulator-integration.