New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import path, remove export in Storage Emulator tests #4377

Merged

tohhsinpei merged 1 commit into master from hsinpei/fix-emulator-directory-flatten-2

Mar 30, 2022

Member

tohhsinpei commented Mar 30, 2022 •

edited

Description

Follow up to #4358. Two quick fixes:

Integration test should not be exporting to a local directory on exit
Integration test for importing nested directory structure was importing from emulator data corresponding to flattened directory structure

There may be one more PR related to this issue addressing double URL encoding (see this and this). But I would like to get this in first.


          Fix import path, remove export in Storage Emulator tests

bb2d0b7

tohhsinpei requested a review from tonyjhuang

March 30, 2022 17:13

tonyjhuang approved these changes

View reviewed changes

tohhsinpei enabled auto-merge (squash)

March 30, 2022 17:14

tohhsinpei merged commit 1bc5644 into master

tohhsinpei deleted the hsinpei/fix-emulator-directory-flatten-2 branch

March 30, 2022 17:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment