Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small change to path forming for Firestore exports #2435

Closed
wants to merge 1 commit into from
Closed

Small change to path forming for Firestore exports #2435

wants to merge 1 commit into from

Conversation

samtstern
Copy link
Contributor

Description

See discussion in #2421

Scenarios Tested

N/A

Sample Commands

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jul 8, 2020
@samtstern samtstern requested a review from yuchenshi July 8, 2020 16:42
@yuchenshi
Copy link
Member

Hmm, I'm not sure about this. Newer Windows versions already recognize / as a path separator as well and that's why the existing logic has been working so far. Your change would make it so that exported metadata files from Windows will no longer work under *nix any more.

@samtstern
Copy link
Contributor Author

@yuchenshi fair enough! It felt so wrong to leave it like this but you're right, it's the lesser evil.

@samtstern samtstern closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samtstern @yuchenshi @googlebot