Fix background functions in functions:shell

[samtstern]

Description

Fix #3490

Scenarios Tested

const functions = require("firebase-functions");

exports.helloWorld = functions.https.onRequest((request, response) => {
  functions.logger.info("Hello logs!", {structuredData: true});
  response.send("Hello from Firebase!");
});

exports.helloPubSub = functions.pubsub.schedule('0 * * * *').onRun(() => {
  functions.logger.info("Hello PubSub!", {structuredData: true});
});

$ firebase --project=demo-project-1234
i  functions: Loaded functions: helloWorld, helloPubSub
⚠  functions: The following emulators are not running, calls to these services will affect production: firestore, database, pubsub, storage
firebase > helloWorld()
Sent request to function.
firebase > >  {"structuredData":true,"severity":"INFO","message":"Hello logs!"}

RESPONSE RECEIVED FROM FUNCTION: 200, Hello from Firebase!

firebase > helloPubSub()
'Successfully invoked function.'
firebase > >  {"structuredData":true,"severity":"INFO","message":"Hello PubSub!"}
>  {"severity":"WARNING","message":"Function returned undefined, expected Promise or value"}
firebase > 

Sample Commands

N/A

[kmcnellis]

What will happen if this finds 2 functions? (aka, it's in 2 regions)

[samtstern]

I guess it'll run the first one? That seems sketchy but also not sure how to improve it without making people type out the region.

[joehan]

LGTM - I agree with your though that the handling for functions in 2 regions is weird, but I think this is the UX that most peeps would expect.

[joehan]

Merging so that we can get this out today - chatted with Kiana offline and she agreed it was good to go.