Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix init hosting:github #3503

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Fix init hosting:github #3503

merged 2 commits into from
Jun 17, 2021

Conversation

samtstern
Copy link
Contributor

Description

Fixes #3498

Scenarios Tested

Valid

$ firebase init hosting

     ######## #### ########  ######## ########     ###     ######  ########
     ##        ##  ##     ## ##       ##     ##  ##   ##  ##       ##
     ######    ##  ########  ######   ########  #########  ######  ######
     ##        ##  ##    ##  ##       ##     ## ##     ##       ## ##
     ##       #### ##     ## ######## ########  ##     ##  ######  ########

You're about to initialize a Firebase project in this directory:

  /private/var/folders/xl/6lkrzp7j07581mw8_4dlt3b000643s/T/tmp.L5QPrZ2B

Before we get started, keep in mind:

  * You are currently outside your home directory
  * You are initializing within an existing Firebase project directory


=== Project Setup

First, let's associate this project directory with a Firebase project.
You can create multiple project aliases by running firebase use --add, 
but for now we'll just set up a default project.

? Please select an option: (Use arrow keys)
❯ Use an existing project 
  Create a new project 
  Add Firebase to an existing Google Cloud Platform project 
  Don't set up a default project

Valid

$ firebase init hosting:github

     ######## #### ########  ######## ########     ###     ######  ########
     ##        ##  ##     ## ##       ##     ##  ##   ##  ##       ##
     ######    ##  ########  ######   ########  #########  ######  ######
     ##        ##  ##    ##  ##       ##     ## ##     ##       ## ##
     ##       #### ##     ## ######## ########  ##     ##  ######  ########

You're about to initialize a Firebase project in this directory:

  /private/var/folders/xl/6lkrzp7j07581mw8_4dlt3b000643s/T/tmp.L5QPrZ2B

Before we get started, keep in mind:

  * You are currently outside your home directory
  * You are initializing within an existing Firebase project directory


=== Project Setup

First, let's associate this project directory with a Firebase project.
You can create multiple project aliases by running firebase use --add, 
but for now we'll just set up a default project.

? Please select an option: (Use arrow keys)
❯ Use an existing project 
  Create a new project 
  Add Firebase to an existing Google Cloud Platform project 
  Don't set up a default project

Invalid

$ firebase init hosting:banana

Error: hosting:banana is not a supported feature; must be one of database, firestore, functions, hosting, hosting:github, storage, emulators, remoteconfig.

Sample Commands

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jun 17, 2021
@samtstern samtstern merged commit ab1a946 into master Jun 17, 2021
andrewheard
andrewheard reviewed Jun 18, 2021
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, Sam.

inlined added a commit that referenced this pull request Jul 3, 2021
@inlined @davidbrenner
@fredzqm @samtstern @andrewheard @dependabot @bkendall @abeisgoat @erikologic @pavelgj @google-oss-bot @huangjeff5 @davidbielik @yuchenshi
Basic create support (#3464)
a7b50e3 
* Unbreak build (#3463)

* Unbreak build

* linter changed its mind

* firestore:delete getConfirmationMessage should include current project (#3457)

The firestore:delete command should notify the user of the current project. This should help users minimize chances of accidental deletions when switching between projects.

* Add asia-southeast1 to RTDB CLI (#3460)

* Fix init database without projectId (#3446)

* Fix init database (#3445)

* Added value check for "feature" parameter in init (#3449)

When the optional feature parameter is provided in a `firebase init
[feature]` command, this checks that its value is a valid choice before
attempting any other initialization.

* Bump trim-newlines from 3.0.0 to 3.0.1 (#3471)

Bumps [trim-newlines](https://github.com/sindresorhus/trim-newlines) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/sindresorhus/trim-newlines/releases)
- [Commits](https://github.com/sindresorhus/trim-newlines/commits)

---
updated-dependencies:
- dependency-name: trim-newlines
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ws from 7.2.3 to 7.4.6 (#3428)

* add node16 to tests (#3462)

* Import/export download tokens (#3444)

* Fixes Storage Emulator startup errors (#3478)

* Bump normalize-url from 4.5.0 to 4.5.1 (#3476)

Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/sindresorhus/normalize-url/releases)
- [Commits](https://github.com/sindresorhus/normalize-url/commits)

---
updated-dependencies:
- dependency-name: normalize-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes download tokens missing when uploading files via Cloud SDK (#3479)

* Follow up to #3420 (#3437)

* Increase waitForPortClosed timeout to 60s (#3483)

* Added validation logic to allow selectResource param type in extensions.yaml (#3489)

* Fix background functions in functions:shell (#3491)

* 9.13.0

* [firebase-release] Removed change log and reset repo after 9.13.0 release

* Fix ext:update issue where local extension is incorrectly inferred as published extension (#3499)

* Add missing changelog entry for #3499 (#3500)

* Fix init hosting:github (#3503)

* 9.13.1

* [firebase-release] Removed change log and reset repo after 9.13.1 release

* Avoid emulator data loss when there an error during export (#3511)

* Ask before overwriting storage.rules (#3510)

* Update CONTRIBUTING.md (#3513)

added note to run `npm install` before `npm link` the first time

* Release Cloud Firestore Emulator v1.13.0. (#3515)

* Basic create support

This change adds support for `firebase --open-sesame golang`.

After running this command, `firebase init` will support Go 1.13
as a langauge for Cloud Functions.

Limitations:

1. .gitignore is empty
2. Customers cannot mix Node and Go code (WAI)
3. There is little validation being done of customer code
4. The actual deployed function params are hard coded; SDK incoming

* Use vendoring to fetch SDK

* Update sample code

* Simplify unarchive pipe

* TSLint

* PR feedback

* Delete Container Registry images left after Functions deployment (#3439)

* Delete Container Registry images left after Functions deployment

* Simplify caching

* Improve error handling and report next steps to users

* lint fixes

* Fix typo

* Increase max function ID length to 63 (#3521)

* Fix crash when deploying zero functions. (#3520)

Previously most code read the desired backend from
`options.config.get("functions.backend")` which was set to the
empty backend correctly. Code that depended on payload.functions.backend
crashed because payload.functions was null when the backend was
empty.

Since optins.config should be firebase.json data, this change
normalizes on payload.functions.backend and ensures that it
is never null while options.config.get('functions') is present
(i.e. when the customer has functions to deploy).

* Use proper replace and get commands

* Update changelog with my recent pushes (#3522)

* 9.14.0

* [firebase-release] Removed change log and reset repo after 9.14.0 release

* Bump glob-parent from 5.0.0 to 5.1.2 (#3472)

* Added deferred provisioning check for Storage and Authentication during extension install (#3497)

Implemented provisioning check helper which checks whether products use by the extension are fully provisioned.

* Generate JSON Schema for firebase.json (#3505)

* Fetch from newly public GH repo

* PR feedback

* Format

Co-authored-by: davidbrenner <david.a.brenner@gmail.com>
Co-authored-by: Fred Zhang <fredzqm@google.com>
Co-authored-by: Sam Stern <samstern@google.com>
Co-authored-by: Andrew Heard <andrew@wizheard.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bryan Kendall <bkend@google.com>
Co-authored-by: Abe Haskins <abeisgreat@abeisgreat.com>
Co-authored-by: Enrico Graziani <mrenrich84@gmail.com>
Co-authored-by: Pavel Jbanov <pavelgj@gmail.com>
Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
Co-authored-by: huangjeff5 <64040981+huangjeff5@users.noreply.github.com>
Co-authored-by: davidbielik <davidbielik@users.noreply.github.com>
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@samtstern @devpeerapong
Fix init hosting:github (firebase#3503)
c13aac1
@bkendall bkendall deleted the ss-fix-3498 branch March 18, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard left review comments

@bkendall bkendall bkendall approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firebase init hosting:github not working on 9.13
3 participants
@samtstern @bkendall @andrewheard