Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing schema files to module #3562

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Adds missing schema files to module #3562

merged 1 commit into from
Jul 8, 2021

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented Jul 8, 2021

Description

Fixes #3561

Scenarios Tested

Tested on head:

» firebase deploy --only hosting --non-interactive

Error: There was an error loading firebase.json:

ENOENT: no such file or directory, open '/Users/bkend/.nvm/versions/node/v12.22.1/lib/node_modules/firebase-tools/schema/firebase-config.json'

And tested with the fixed package:
» firebase deploy --only hosting --non-interactive

=== Deploying to 'project'...

i deploying hosting
i hosting[project]: beginning deploy...

@bkendall bkendall requested review from joehan and samtstern July 8, 2021 19:53
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jul 8, 2021
@@ -110,6 +110,7 @@
"google-auth-library": "^6.1.3",
"inquirer": "~6.3.1",
"js-yaml": "^3.13.1",
"JSONStream": "^1.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying sorting artifact based on npm version

@bkendall bkendall merged commit 4133712 into master Jul 8, 2021
@bkendall bkendall deleted the b3561 branch July 8, 2021 20:02
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v9.15.0] Latest release breaks FirebaseExtended/action-hosting-deploy GitHub action
2 participants