Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth_time emulator behavior should match production (auth_time is now set to user's last sign in time). (#3608) #3610

Closed

Conversation

lovelle-cardoso
Copy link
Contributor

Description

Fixes #3608 so that emulator sets auth_time the same way production does (auth_time should match lastLoginAt in seconds)

Scenarios Tested

Added unit test to src/test/emulators/auth/misc.spec.ts called "should populate auth_time to match lastLoginAt (in seconds since epoch)"

This unit test...

  1. Registers a user
  2. Exchanges a refresh token for a new token
  3. Checks that the new token's auth_time matches the user's lastLoginAt in seconds.

@google-cla
Copy link

google-cla bot commented Jul 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lovelle-cardoso
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jul 27, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@lovelle-cardoso lovelle-cardoso deleted the fix-auth_time branch July 27, 2021 19:16
@lovelle-cardoso
Copy link
Contributor Author

My commit author wasn't correct. So I fixed it here: #3611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth_time doesn't match user's lastSignInTime (always matches iat instead)
1 participant