Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage emulator fixes and added rewriteTo support #3647

Merged
merged 41 commits into from
Mar 15, 2022
Merged

Storage emulator fixes and added rewriteTo support #3647

merged 41 commits into from
Mar 15, 2022

Commits on Mar 14, 2022

  1. Added missing return type

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    2eece8e View commit details
    Browse the repository at this point in the history

  2. Set default cache-control header

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    43b925b View commit details
    Browse the repository at this point in the history

  3. Try to derive eTag from file bytes

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    d097baa View commit details
    Browse the repository at this point in the history

  4. Use content-encoding from metadata

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    1044cde View commit details
    Browse the repository at this point in the history

  5. Added in other file headers

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    199082b View commit details
    Browse the repository at this point in the history

  6. Improved comment

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    5aa6106 View commit details
    Browse the repository at this point in the history

  7. Extracted out crc32c encoding to separate function

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    c91e5db View commit details
    Browse the repository at this point in the history

  8. Added in x-goog-hash header with encoded crc32c value and MD5 hash

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    83d634f View commit details
    Browse the repository at this point in the history

  9. Match 404 object errors to API

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    278ccc9 View commit details
    Browse the repository at this point in the history

  10. Fixed range requests 

    Simplified to use express' Request#range method and corrected end to be used as an inclusive bound
    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    084477c View commit details
    Browse the repository at this point in the history

  11. When STORAGE_EMULATOR_DEBUG env is set, still return 501 status code

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    8f82b87 View commit details
    Browse the repository at this point in the history

  12. Added support for rewriteTo and copyTo in the storage emulator

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    81f5e44 View commit details
    Browse the repository at this point in the history

  13. Added contentDisposition into metadata

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    ff21894 View commit details
    Browse the repository at this point in the history

  14. Convert custom metadata values to strings and added integration test … 

    …to admin SDK for removing values
    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    3e06fad View commit details
    Browse the repository at this point in the history

  15. Match 404 object errors to API for non-GET endpoints

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    f469868 View commit details
    Browse the repository at this point in the history

  16. Changed to use declared imports to match other fs usage

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    99c1e52 View commit details
    Browse the repository at this point in the history

  17. No need to check for directory existence before trying to create it w… 

    …hen using the recursive flag
    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    4d6b812 View commit details
    Browse the repository at this point in the history

  18. Stored files flat inside bucket directory, and URL encode the path co… 

    …mponents
    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    cd64b38 View commit details
    Browse the repository at this point in the history

  19. Fixed typo in skipped test

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    f0145bf View commit details
    Browse the repository at this point in the history

  20. Corrected list objects endpoint when using prefix and delimiter to re… 

    …turn correct items and include prefixes
    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    f7dfda9 View commit details
    Browse the repository at this point in the history

  21. Support for pageTokens and maxResults in objects: list

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    812f337 View commit details
    Browse the repository at this point in the history

  22. Refactored Firebase storage#listAll endpoint to call generic listItems

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    5c4e5e5 View commit details
    Browse the repository at this point in the history

  23. #upload test to check provided custom metadata is set

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    4c6ed44 View commit details
    Browse the repository at this point in the history

  24. Better tests for #copy to check original files metadata is copied

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    bddf660 View commit details
    Browse the repository at this point in the history

  25. Updated #copy() to overwrite all custom metadata, not only provided keys

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    e3c4f3e View commit details
    Browse the repository at this point in the history

  26. Updated #copy() to convert null custom metadata values to empty strings

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    10adc2a View commit details
    Browse the repository at this point in the history

  27. Refactored objects: rewrite / copy endpoint to method in storage layer

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    cc40156 View commit details
    Browse the repository at this point in the history

  28. Handle firebaseStorageDownloadTokens for objects: rewrite / copy

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    1bee89e View commit details
    Browse the repository at this point in the history

  29. Consistent case for constant test variable

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    f4d6eec View commit details
    Browse the repository at this point in the history

  30. Changed iterating over objects with Object.keys to use Object.entries

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    3d5f356 View commit details
    Browse the repository at this point in the history

  31. Clearer circumventing the type-system

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    6808c93 View commit details
    Browse the repository at this point in the history

  32. Base eTags on object generation and metadata generation for uniquenes… 

    …s across objects regardless of file content
    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    182cee9 View commit details
    Browse the repository at this point in the history

  33. Refactored StorageLayer#listItemsAndPrefixes to use #listItems and mo… 

    …ved specfic Firebase and gcloud formats to those APIs
    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    3e4afc4 View commit details
    Browse the repository at this point in the history

  34. Removed unused import

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    3e9a02b View commit details
    Browse the repository at this point in the history

  35. Handled cache control and content language metadata and added tests

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    091410a View commit details
    Browse the repository at this point in the history

  36. Integration tests for File#exists

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    b03f28a View commit details
    Browse the repository at this point in the history

  37. Updated CHANGELOG

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    140be80 View commit details
    Browse the repository at this point in the history

  38. Comment on boolean argument

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    3627742 View commit details
    Browse the repository at this point in the history

  39. Merge branch 'master' into emulator-fixes

    @rhodgkins
    rhodgkins committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    b4f1457 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Fixed end to end test storage import/export

    @rhodgkins
    rhodgkins committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    8b3c692 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into emulator-fixes

    @rhodgkins
    rhodgkins committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    efa57d4 View commit details
    Browse the repository at this point in the history