Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Firebase Function deploy bugs. #3668

Merged
merged 5 commits into from
Aug 12, 2021
Merged

Fix Firebase Function deploy bugs. #3668

merged 5 commits into from
Aug 12, 2021

Commits on Aug 12, 2021

  1. Fix bug where dotenv feature was not behind the preview flag. 

    This is embarrassing. I must have removed the preview check while refactoring the code after PR feedback. Also improving the logging logic to not log anything if no local dotenv files are found.
    @taeold
    taeold committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    b9df3f5 View commit details
    Browse the repository at this point in the history

  2. Fix test.

    @taeold
    taeold committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    68ae4b8 View commit details
    Browse the repository at this point in the history

  3. Prettier please.

    @taeold
    taeold committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    d39838f View commit details
    Browse the repository at this point in the history

  4. Fix more test.

    @taeold
    taeold committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    04d144b View commit details
    Browse the repository at this point in the history

  5. Fix bug where wrong FIREBASE_CONFIG value was set.

    @taeold
    taeold committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    c05862d View commit details
    Browse the repository at this point in the history