Fix an issue where emulator:exec would not work without a project ID #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
commented
Aug 13, 2021
| @@ -330,7 +329,7 @@ export async function startAll(options: Options, showUI: boolean = true): Promis | |||
| const hubLogger = EmulatorLogger.forEmulator(Emulators.HUB); | |||
| hubLogger.logLabeled("BULLET", "emulators", `Starting emulators: ${targets.join(", ")}`); | |||
|
|
|||
| const projectId: string = needProjectId(options); | |||
| const projectId: string = getProjectId(options) || ""; // TODO: Next breaking change, consider making this fall back to demo project. | |||
There was a problem hiding this comment.
I think we should strongly consider giving this a sane default, but I'm afraid to change the behavior at all given our recent run ins with Hyrum's law.
yuchenshi
approved these changes
Aug 13, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
…irebase#3684) * fix issue where the emulator:exec would not work without a project id * add todo * changelog! * formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where emulator:exec would not work without a project ID. Fixes #3681
Scenarios Tested
I'm able to run
firebase emulators:exec test.jswithout the error described in #3681, as long as the functions emulator is not running. This matches the behavior from <9.16.0