Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary escape char behind #. #3706

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Remove unnecessary escape char behind #. #3706

merged 2 commits into from
Sep 9, 2021

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Aug 25, 2021

Follows up github.com//pull/3703.

Regex implementation ignores superflous escape chars (e.g. #):

> "#".match(RegExp("#"))
[ '#', index: 0, input: '#', groups: undefined ]
> "#".match(RegExp("\\#"))
[ '#', index: 0, input: '#', groups: undefined ]

Cleaning up to keep our future-selves sane 馃Ч .

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Aug 25, 2021
@taeold taeold requested a review from inlined August 25, 2021 22:48
colerogers
colerogers reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@colerogers colerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taeold taeold merged commit e5de747 into master Sep 9, 2021
@taeold taeold deleted the dl-dotenv-cleanup branch September 9, 2021 20:19
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@taeold @devpeerapong
Remove unnecessary escape char behind #. (firebase#3706)
00b5737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined approved these changes

@colerogers colerogers colerogers approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taeold @inlined @colerogers