Hosting deploy migration to apiv2, typescript, project-scoped #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbleigh
reviewed
Jan 10, 2022
joehan
approved these changes
Feb 17, 2022
| /** | ||
| * Prepare creates versions for each Hosting site to be deployed. | ||
| */ | ||
| export async function prepare(context: any, options: any): Promise<void> { |
There was a problem hiding this comment.
Can we use the options type from options.ts so these warnings are silenced?
|
Derp, I didn't realize automerge was on - feel free to make the options switch another time (or we can try to do it as a LSC) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've updated the hosting deploy path to be:
This helpfully fixes the issue where a deploy can go to a site not on the same project, which is definitely not intended.
Fixes #2558
Scenarios Tested
firebase deploy --only hostingfirebase hosting:channel:deploy staging