Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StorageRulesManagerRegistry to handle rules files for multiple targets #4281

Merged
merged 18 commits into from
Mar 16, 2022
Merged

Add StorageRulesManagerRegistry to handle rules files for multiple targets #4281

merged 18 commits into from
Mar 16, 2022

Commits on Mar 16, 2022

  1. Address PR feedback; add JSDocs for new method

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    586e660 View commit details
    Browse the repository at this point in the history

  2. Make StorageRulesManager an interface; add StorageRulesManagerRegistry

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    fff9889 View commit details
    Browse the repository at this point in the history

  3. Modify RulesetProvider to take resource parameter

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    fc487e4 View commit details
    Browse the repository at this point in the history

  4. Rebase; fix lint error

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    edb0bd7 View commit details
    Browse the repository at this point in the history

  5. Change emulator arg to take SourceFile only

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1ddd733 View commit details
    Browse the repository at this point in the history

  6. PR feedback, mostly re: API usage

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    6f45411 View commit details
    Browse the repository at this point in the history

  7. Don't delete source file or ruleset on stop(); add CHANGELOG

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    0594bf2 View commit details
    Browse the repository at this point in the history

  8. Address PR feedback

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    8e42a13 View commit details
    Browse the repository at this point in the history

  9. Moved Storage rules integration tests under scripts/ (#4309)

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    8f3d045 View commit details
    Browse the repository at this point in the history

  10. Make StorageRulesManager an interface; add StorageRulesManagerRegistry

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    007e1f4 View commit details
    Browse the repository at this point in the history

  11. Modify RulesetProvider to take resource parameter

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    18dbd2f View commit details
    Browse the repository at this point in the history

  12. Change emulator arg to take SourceFile only

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    fc6cdf0 View commit details
    Browse the repository at this point in the history

  13. PR feedback, mostly re: API usage

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    b7c5de5 View commit details
    Browse the repository at this point in the history

  14. Don't delete source file or ruleset on stop(); add CHANGELOG

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f221cb8 View commit details
    Browse the repository at this point in the history

  15. Address PR feedback

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    6ed793c View commit details
    Browse the repository at this point in the history

  16. Merge branch 'master' into hsinpei/storage-emulator-multiple-targets-3

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    0c8c165 View commit details
    Browse the repository at this point in the history

  17. Fix lint

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    2107f90 View commit details
    Browse the repository at this point in the history

  18. Add test for failing to find rules for given resource

    @tohhsinpei
    tohhsinpei committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    76d7a42 View commit details
    Browse the repository at this point in the history