Add integration test for multiple storage targets #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohhsinpei
force-pushed
the
hsinpei/storage-emulator-multiple-targets-4
branch
from
2e57dd6
to
be7c23c
Compare
tohhsinpei
force-pushed
the
hsinpei/storage-emulator-multiple-targets-4
branch
from
be7c23c
to
4c7d74c
Compare
tonyjhuang
reviewed
Mar 17, 2022
scripts/storage-emulator-integration/multiple-targets/storage.main.rules
Outdated
Show resolved
Hide resolved
scripts/storage-emulator-integration/multiple-targets/storage.other.rules
Outdated
Show resolved
Hide resolved
tohhsinpei
force-pushed
the
hsinpei/storage-emulator-multiple-targets-4
branch
from
2f40f04
to
6c3d628
Compare
tohhsinpei
force-pushed
the
hsinpei/storage-emulator-multiple-targets-4
branch
from
6c3d628
to
a479aee
Compare
tonyjhuang
approved these changes
Mar 17, 2022
tohhsinpei
force-pushed
the
hsinpei/storage-emulator-multiple-targets-4
branch
from
c81d3f2
to
a479aee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an integration test for #4281, verifying that #3390 is indeed fixed. The test does the following:
mainandotherto two different Storage bucketsstorage.main.rulesandstorage.other.rulesrespectively)Sample Commands
npm run test:storage-emulator-integrationwill run the usual integration testscripts/storage-emulator-integration/tests.tsas well as this new integration test.