Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CSM response without secrets #4425

Merged
merged 3 commits into from
Apr 9, 2022
Merged

Handle CSM response without secrets #4425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db0cfb0
Handle CSM response without secrets
inlined Apr 8, 2022
6dbf876
Prettify.
taeold Apr 8, 2022
736aec7
Add changelog.
taeold Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
- Improves support for prerelease versions in `ext:dev:publish` (#4244).
- Fixes console error on large uploads to Storage Emulator (#4407).
- Fixes cross-platform incompatibility with Storage Emulator exports (#4411).
- Fixes issue where function deployment errored on projects without secrets (#4425).
2 changes: 1 addition & 1 deletion src/gcp/secretManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export async function listSecrets(projectId: string, filter?: string): Promise<S
: { ...baseOpts, queryParams: { ...baseOpts?.queryParams, pageToken } };
const res = await client.get<Response>(path, opts);

for (const s of res.body.secrets) {
for (const s of res.body.secrets || []) {
secrets.push({
...parseSecretResourceName(s.name),
labels: s.labels ?? {},
Expand Down