Fix comments from Auth Blocking Triggers PR #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Apr 14, 2022
| unregisterTrigger(ep: backend.Endpoint): Promise<void> { | ||
| if (!backend.isBlockingTriggered(ep)) { | ||
| return Promise.resolve(); // this should never happen | ||
| } | ||
| this.triggerQueue = this.triggerQueue.then(() => this.unregisterTriggerLocked(ep)); |
There was a problem hiding this comment.
Q: So I understand that we are building a chain of promises to make sure trigger registration happens sequentially.
But doesn't something have to wait for all of these chain of promises are all fulfilled before we declare "hey deployment is done!". If we don't do this, then aren't we just banking on it being completed before the CLI process finishes (at which it will make sure all promises are fulfilled)?
There was a problem hiding this comment.
We return the promise below. By modifying the promise in place we're returning a promise for the latest enqueued operation. Fabricator waits on this promise before resolving setTrigger or unsetTrigger.
inlined
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changed addresses post merge comments from #4395