Fixing invalid version error when emulating functions #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
reviewed
Apr 28, 2022
| @@ -129,6 +129,18 @@ export class Delegate { | |||
| env: backend.EnvironmentVariables | |||
| ): Promise<backend.Backend> { | |||
| if (previews.functionsv2) { | |||
| if (semver.valid(this.sdkVersion)) { | |||
There was a problem hiding this comment.
Should this be
if (!semver.valid(this.sdkVersion))instead?
There was a problem hiding this comment.
Good catch, that's what i get for moving too quickly.
taeold
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When unable to identify the version of firebase-functions in use, we were throwing
TypeError: Invalid Version:errors due to trying to parse "" into Semver. This should fix #4403, where some users are experiencing this when trying to emulate functions.