-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the IAM role binding process #4511
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
25cd034
change up ordering, add jump out points, and add sleep
colerogers 1f0f79f
linting
colerogers 99ef5d7
yanking out sleep, adding in a better error message for the first dep…
colerogers 3216dd1
Merge remote-tracking branch 'origin/master' into colerogers.enhance-…
colerogers ca6a614
adding changelog
colerogers File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
- Add support for secrets to v2 functions (#4451). | ||
- Fixes an issue where `ext:export` would write different param values than what it displayed in the prompt (#4515). | ||
- Enhances the functions IAM permission process and updates the error messages (#4511). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { bold } from "cli-color"; | ||
import { serviceUsageOrigin } from "../api"; | ||
import { Client } from "../apiv2"; | ||
import { FirebaseError } from "../error"; | ||
import * as utils from "../utils"; | ||
|
||
const apiClient = new Client({ | ||
urlPrefix: serviceUsageOrigin, | ||
apiVersion: "v1beta1", | ||
}); | ||
|
||
/** | ||
* Generate the service account for the service. Note: not every service uses the endpoint. | ||
* @param projectNumber gcp project number | ||
* @param service the service api (ex~ pubsub.googleapis.com) | ||
* @returns | ||
*/ | ||
export async function generateServiceIdentity( | ||
projectNumber: string, | ||
service: string, | ||
prefix: string | ||
) { | ||
utils.logLabeledBullet(prefix, `generating the service identity for ${bold(service)}...`); | ||
try { | ||
return await apiClient.post<unknown, unknown>( | ||
`projects/${projectNumber}/services/${service}:generateServiceIdentity` | ||
); | ||
} catch (err: unknown) { | ||
throw new FirebaseError(`Error generating the service identity for ${service}.`, { | ||
original: err as Error, | ||
}); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯 dedication to DevX!