-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storage gcs conformance tests #4869
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4869 +/- ##
==========================================
- Coverage 56.93% 56.73% -0.20%
==========================================
Files 288 288
Lines 19062 19110 +48
Branches 3775 3792 +17
==========================================
- Hits 10853 10843 -10
- Misses 7290 7350 +60
+ Partials 919 917 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scripts/storage-emulator-integration/conformance/firebase-js-sdk.test.ts
Outdated
Show resolved
Hide resolved
* deploy working with using the default compute sa & running a GET request * fix test cases * formatter * cleaning up code post merge * add changelog entry
…ckend (#4873) * Only start eventarc emulator when there is at least one emulatable backend * Enable automatic port finding * Add changelog * Format changelog
scripts/storage-emulator-integration/conformance/firebase.endpoints.test.ts
Outdated
Show resolved
Hide resolved
scripts/storage-emulator-integration/conformance/firebase.endpoints.test.ts
Outdated
Show resolved
Hide resolved
scripts/storage-emulator-integration/conformance/gcs.endpoints.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to touch a lot of files... is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing those bits :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the tests and refactor!
* move * copy * move * save * pull out firebase and gcs tests * internal * env * gcs sdk tests * clean * remove tests.ts * lint * remove redundant config * persistence * remove creds * lint * gcs endpoint auth * fix firebase conformance tests * revert * clean * shrinkwrap * no async * merge * remove * fix test and lint * lint * multipart * fix tests * save * fix tests * fix metadata * revert package * fix * lint * Support CEL expressions in the v1alpha1 wire format provided by the SDK (#4809) * Add v2 Schedule Triggers to deploy (#4764) * deploy working with using the default compute sa & running a GET request * fix test cases * formatter * cleaning up code post merge * add changelog entry * Only start eventarc emulator when there is at least one emulatable backend (#4873) * Only start eventarc emulator when there is at least one emulatable backend * Enable automatic port finding * Add changelog * Format changelog * Persist CF3 param values to disk, and read them if available during deploy (#4787) * 11.7.0 * [firebase-release] Removed change log and reset repo after 11.7.0 release * revert js sdk tests * fix tests * comments * remove mocha * remove deep eql * revert shrinkwrap * changelog * lint Co-authored-by: Victor Fan <vsfan@google.com> Co-authored-by: Cole Rogers <colerogers@users.noreply.github.com> Co-authored-by: huangjeff5 <64040981+huangjeff5@users.noreply.github.com> Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
Description
/storage/v1/b/:bucketId/o/:objectId
url patternScenarios Tested
Sample Commands