Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update refresh token validation so it throws INVALID_REFRESH_TOKEN when user is not found #4990

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

lisajian
Copy link
Contributor

Description

As the title suggests. Currently, when user is not found, it throws Error: Internal state invariant broken: no user with ID: {userId}. This fixes a regression that was introduced by #4475

Also filed b/247157333 for further investigation about any other deviations from prod

Scenarios Tested

npm run test passes

Sample Commands

N/A

@codecov-commenter
Copy link

Codecov Report

Base: 56.98% // Head: 56.99% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9307dd5) compared to base (b8f223f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4990      +/-   ##
==========================================
+ Coverage   56.98%   56.99%   +0.01%     
==========================================
  Files         292      292              
  Lines       19506    19508       +2     
  Branches     3902     3902              
==========================================
+ Hits        11115    11119       +4     
+ Misses       7454     7452       -2     
  Partials      937      937              
Impacted Files Coverage Δ
src/emulator/auth/state.ts 85.43% <100.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lisajian lisajian merged commit 429280d into master Sep 17, 2022
@yuchenshi yuchenshi deleted the lj-refresh branch September 17, 2022 05:09
christhompsongoogle pushed a commit that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants