Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support source deploy option #7169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matthewaptaylor
Copy link

Description

This PR adds an option to the Firebase CLI to override the functions.source config option on firebase deploy. This is much like the option which overrides the public directory when deploying to Hosting.

The use case is where a user deploys a functions package whose structure is not supported by Firebase, such as a monorepo package. When deploying a functions package in a monorepo, a common strategy is to create a directory which contains the functions and other internal monorepo dependencies, and deploy that. One such example is isolate-package. Other strategies are mentioned in #653.

Scenarios Tested

  • Tested running firebase deploy --only functions --source apps/functions/deploy, which deploys the deploy directory.
  • Tested running firebase deploy --only functions, which deploys the folder specified in firebase.json.

Sample Commands

firebase deploy --only functions --source apps/functions/deploy
firebase deploy --only functions -s apps/functions/deploy
firebase deploy --source apps/functions/deploy
firebase deploy -s apps/functions/deploy

Copy link

google-cla bot commented May 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant