Skip to content

Commit

Permalink
chore: update analyse issues surfaced from latest Flutter SDK (#12783)
Browse files Browse the repository at this point in the history
  • Loading branch information
russellwheatley committed May 15, 2024
1 parent ce91236 commit 614a5a6
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ void runDocumentReferenceTests() {
(DocumentSnapshot<Map<String, dynamic>> snapshot) {
expect(snapshot.exists, isFalse);
},
count: 1,
reason: 'Stream should only have been called once.',
),
);
Expand All @@ -102,7 +101,6 @@ void runDocumentReferenceTests() {
(DocumentSnapshot<Map<String, dynamic>> snapshot) {
expect(snapshot.exists, isFalse);
},
count: 1,
reason: 'Stream should only have been called once.',
),
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ void runSecondDatabaseTests() {
snapshot.docs[0];
expect(documentSnapshot.data()['foo'], equals('bar'));
},
count: 1,
reason: 'Stream should only have been called once.',
),
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void main() {
group('HttpsCallable', () {
group('call()', () {
test('parameter validation accepts null values', () async {
expect((await httpsCallable!.call(null)).data, isNull);
expect((await httpsCallable!.call()).data, isNull);
});

test('parameter validation accepts string values', () async {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ class MessageWidget extends StatelessWidget {
decoration: BoxDecoration(
color: isFromUser
? Theme.of(context).colorScheme.primaryContainer
: Theme.of(context).colorScheme.surfaceVariant,
: Theme.of(context).colorScheme.surfaceContainerHighest,
borderRadius: BorderRadius.circular(18),
),
padding: const EdgeInsets.symmetric(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void main() {
});

test('accepts `null arguments', () async {
HttpsCallableResult result = await callable(null);
HttpsCallableResult result = await callable();
expect(result.data, equals('null'));
});

Expand Down Expand Up @@ -241,7 +241,7 @@ void main() {
),
);

HttpsCallableResult results = await timeoutCallable(null);
HttpsCallableResult results = await timeoutCallable();
expect(results.data, equals('null'));
},
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ void main() {
subscription = stream.listen(
expectAsync1(
(User? user) {},
count: 1,
reason: 'Stream should only call once',
),
);
Expand Down

0 comments on commit 614a5a6

Please sign in to comment.