Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): migrate remaining examples & e2e tests to null-safety #7393

Merged
merged 19 commits into from Nov 25, 2021

Conversation

pr-Mais
Copy link
Member

@pr-Mais pr-Mais commented Nov 19, 2021

Description

Migrate all example apps and e2e tests to null-safety and remove //@dart=2.9.

Included plugins:

  • Core
  • Auth
  • Storage
  • Functions
  • Firestore
  • Messaging
  • Crashlytics
  • Remote Config
  • App Check

Not included:

Related Issues

None.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Nov 19, 2021
@pr-Mais pr-Mais marked this pull request as draft November 19, 2021 15:08
@pr-Mais pr-Mais force-pushed the @mais/examples branch 2 times, most recently from 27e3297 to 729d5f2 Compare November 22, 2021 11:37
@pr-Mais pr-Mais force-pushed the @mais/examples branch 3 times, most recently from 8dad3a5 to 0424012 Compare November 22, 2021 16:31
@pr-Mais pr-Mais marked this pull request as ready for review November 22, 2021 21:43
@pr-Mais
Copy link
Member Author

pr-Mais commented Nov 22, 2021

TODO: some plugins still running 0 tests

@pr-Mais pr-Mais requested a review from Ehesp November 24, 2021 09:51
@Salakar Salakar changed the title refactor(*): migrate examples & e2e tests to null-safety refactor(*): migrate remaining examples & e2e tests to null-safety Nov 25, 2021
@Salakar Salakar merged commit 0ca85e5 into master Nov 25, 2021
@Salakar Salakar deleted the @mais/examples branch November 25, 2021 09:39
@firebase firebase locked and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants