Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Initialize Firebase app from test driver now as google service files removed from example app #7376

Closed
wants to merge 2 commits into from

Conversation

russellwheatley
Copy link
Member

Description

Initialize firebase app from test driver code across packages when appropriate.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Nov 16, 2021
@russellwheatley russellwheatley changed the title tests: initialise firebase app from test driver tests: Initialize Firebase app from test driver now as google service files removed from example app Nov 16, 2021
@russellwheatley russellwheatley changed the title tests: Initialize Firebase app from test driver now as google service files removed from example app test: Initialize Firebase app from test driver now as google service files removed from example app Nov 16, 2021
@pr-Mais
Copy link
Member

pr-Mais commented Nov 23, 2021

Addressed in #7393

@pr-Mais pr-Mais closed this Nov 23, 2021
@firebase firebase locked and limited conversation to collaborators Dec 24, 2021
@Lyokone Lyokone deleted the @russell/update-init-app branch November 29, 2022 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants