Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle query.orderBy(startAt:).orderBy() #9185

Merged
merged 14 commits into from Sep 20, 2022
Merged

fix: handle query.orderBy(startAt:).orderBy() #9185

merged 14 commits into from Sep 20, 2022

Conversation

rrousselGit
Copy link
Contributor

@rrousselGit rrousselGit commented Jul 21, 2022 •
edited by russellwheatley

Description

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@rrousselGit
feat!: The low-level interface of Queries/Document
9c20dfc 
references are improved to no-longer use `Object?` in various situations

This change is breaking, as classes such as FirestoreDcoumentReference
now take two generic arguments instead of one.
@rrousselGit
fix: handle query.orderBy(startAt:).orderBy()
9f90e26
@rrousselGit
add test
e645c8a
@russellwheatley russellwheatley added type: bug Something isn't working plugin: odm labels Jul 22, 2022
This was linked to issues Aug 3, 2022
🐛 [cloud_firestore_odm] Queries with multiple orderBy and a startAt throw an assertion error #9062
Closed
🐛 [cloud_firestore_odm] Allow passing startAt only on the first orderBy query #9063
Closed
@rrousselGit rrousselGit marked this pull request as ready for review September 8, 2022 08:46
@rrousselGit rrousselGit merged commit 62396e8 into master Sep 20, 2022
@rrousselGit rrousselGit deleted the @rrousselGit/odm-order-by branch September 20, 2022 09:39
@firebase firebase locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lyokone Lyokone Lyokone approved these changes

@Salakar Salakar Salakar approved these changes

@kroikie kroikie Awaiting requested review from kroikie kroikie is a code owner

Assignees
No one assigned
Labels
plugin: odm type: bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@rrousselGit @Lyokone @Salakar @russellwheatley