Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): pass StorageMetadata as nullable for putFile() API. Metadata ought to be inferred from File. #12612

Merged
merged 17 commits into from
Apr 23, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Apr 9, 2024

Description

Storage emulator doesn't seem to infer type so I tested on the live project. Below shows uploading an image with and without changes from this PR which shows type inference is now working on android:

Screenshot 2024-04-09 at 11 37 59

Related Issues

fixes #12570
fixes #12363

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(storage): pass StorageMetadata as nullable for putFile() API. Metadata ought to be inferred from File. fix(storage, android): pass StorageMetadata as nullable for putFile() API. Metadata ought to be inferred from File. Apr 9, 2024
@russellwheatley russellwheatley changed the title fix(storage, android): pass StorageMetadata as nullable for putFile() API. Metadata ought to be inferred from File. fix(storage, android): pass StorageMetadata as nullable for putFile() API. Metadata ought to be inferred from File. Apr 16, 2024
@russellwheatley russellwheatley changed the title fix(storage, android): pass StorageMetadata as nullable for putFile() API. Metadata ought to be inferred from File. fix(storage): pass StorageMetadata as nullable for putFile() API. Metadata ought to be inferred from File. Apr 16, 2024
@russellwheatley russellwheatley marked this pull request as ready for review April 16, 2024 14:43
Copy link
Contributor

@Lyokone Lyokone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what we discussed, ie: inferring types doesn't work on the emulator, LGTM

@russellwheatley russellwheatley merged commit e75d134 into master Apr 23, 2024
24 checks passed
@russellwheatley russellwheatley deleted the storage-12570 branch April 23, 2024 09:11
@firebase firebase locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants