Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump Firebase iOS SDK to 8.9.0 #7289

Merged
merged 4 commits into from Nov 3, 2021
Merged

feat: bump Firebase iOS SDK to 8.9.0 #7289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c080e9b
chore: bump native sdk versions
russellwheatley Nov 2, 2021
d01c02d
chore: revert android version bump. separating PRs.
russellwheatley Nov 3, 2021
ee268ae
fix(firebase_analytics, ios): fix channel name (#7295)
russellwheatley Nov 3, 2021
5f003e9
Merge branch 'master' into @russell/bump-sdks
Salakar Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/overview.mdx
View file
Open in desktop
Expand Up @@ -239,14 +239,14 @@ Once initialized, you're ready to get started using FlutterFire!

Currently the Firestore iOS SDK depends on some 500k lines of mostly C++ code which can take upwards of 5 minutes to build in XCode. To reduce build times significantly, you can use a pre-compiled version by adding 1 line to your `ios/Podfile` inside your Flutter project;

`pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '8.8.0'`
`pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '8.9.0'`

Add this line inside your target 'Runner' do block in your Podfile, e.g.:

```
# ...
target 'Runner' do
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '8.8.0'
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '8.9.0'
# ...
end
```
Expand Down Expand Up @@ -281,7 +281,7 @@ Open your `/ios/Podfile` or `/macos/Podfile` file and add any of the globals bel

```ruby
# Override Firebase SDK Version
$FirebaseSDKVersion = '8.8.0'
$FirebaseSDKVersion = '8.9.0'
```

## Next Steps
Expand Down
6 changes: 3 additions & 3 deletions packages/firebase_analytics/firebase_analytics/ios/Classes/FLTFirebaseAnalyticsPlugin.m
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@
NSString *const kAnalyticsStorage = @"analyticsStorage";
NSString *const kUserId = @"userId";

NSString *const kFLTFirebaseCrashlyticsChannelName = @"plugins.flutter.io/firebase_analytics";
NSString *const kFLTFirebaseAnalyticsChannelName = @"plugins.flutter.io/firebase_analytics";

@implementation FLTFirebaseAnalyticsPlugin {
}
Expand All @@ -42,7 +42,7 @@ + (instancetype)sharedInstance {

+ (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
FlutterMethodChannel *channel =
[FlutterMethodChannel methodChannelWithName:kFLTFirebaseCrashlyticsChannelName
[FlutterMethodChannel methodChannelWithName:kFLTFirebaseAnalyticsChannelName
binaryMessenger:[registrar messenger]];
FLTFirebaseAnalyticsPlugin *instance = [FLTFirebaseAnalyticsPlugin sharedInstance];
[registrar addMethodCallDelegate:instance channel:channel];
Expand Down Expand Up @@ -185,7 +185,7 @@ - (NSString *_Nonnull)firebaseLibraryVersion {
}

- (NSString *_Nonnull)flutterChannelName {
return kFLTFirebaseCrashlyticsChannelName;
return kFLTFirebaseAnalyticsChannelName;
}

- (NSDictionary *_Nonnull)pluginConstantsForFIRApp:(FIRApp *_Nonnull)firebaseApp {
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_core/firebase_core/ios/firebase_sdk_version.rb
View file
Open in desktop
@@ -1,4 +1,4 @@
# https://firebase.google.com/support/release-notes/ios
def firebase_sdk_version!()
'8.8.0'
'8.9.0'
end