Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: web JS v9.9.0 SDK bump #9075

Merged
merged 2 commits into from Jul 11, 2022
Merged

feat: web JS v9.9.0 SDK bump #9075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cad63a4
feat: web JS v9.9.0 SDK bump
russellwheatley Jul 11, 2022
7b3bc22
format
russellwheatley Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firebase_core/firebase_core_web/lib/src/firebase_sdk_version.dart
View file
Open in desktop
Expand Up @@ -6,4 +6,4 @@
part of firebase_core_web;

/// The currently supported Firebase JS SDK version.
const String supportedFirebaseJsSdkVersion = '9.8.1';
const String supportedFirebaseJsSdkVersion = '9.9.0';
6 changes: 1 addition & 5 deletions tests/test_driver/firebase_storage/firebase_storage_e2e.dart
View file
Open in desktop
Expand Up @@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.

import 'package:drive/drive.dart';
import 'package:firebase_auth/firebase_auth.dart';
import 'package:firebase_core/firebase_core.dart';
import 'package:firebase_storage/firebase_storage.dart';

Expand All @@ -22,10 +21,7 @@ void setupTests() {
);
await FirebaseStorage.instance
.useStorageEmulator(testEmulatorHost, testEmulatorPort);
await FirebaseAuth.instance.useAuthEmulator(testEmulatorHost, 9099);
if (FirebaseAuth.instance.currentUser == null) {
await FirebaseAuth.instance.signInAnonymously();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this was removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this. It's not an issue for web, macOS and iOS so not sure if it's needed anymore? can reinstate if it's still an issue for android.

// Add a write only file
await FirebaseStorage.instance
.ref('writeOnly.txt')
Expand Down