Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IOS build error with firestore-ios-sdk-frameworks #9765

Closed
wants to merge 1 commit into from

Conversation

leehack
Copy link

@leehack leehack commented Oct 20, 2022

Description

Potential fix for #9761
The IOS build is failing with cloud_functions: 4.0.1 and pre-compiled ios SDK together.

This might be a missing change of #9708

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

  # required until firestore-ios-sdk-frameworks is updated, otherwise users of that distribution will have compile failures
  # see invertase/firestore-ios-sdk-frameworks#59
@leehack leehack changed the title Fix IOS build error with firestore-ios-sdk-frameworks fix: IOS build error with firestore-ios-sdk-frameworks Oct 20, 2022
@russellwheatley
Copy link
Member

Closing this out for reason described here

@firebase firebase locked and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants